iCloud notes not syncing between iphone and mac

Check which account the notes are actually in, it's usually that. In Notes on the phone go back to the Folders view: if there's an On My iPhone section and your notes are under that instead of under iCloud, they were never going to sync. Long press a note, Move, pick an iCloud folder. Then Settings, Notes, Default Account, set it to iCloud so new ones land in the right place. On the Mac, System Settings, your name, iCloud, and make sure Notes is on there too, it's a separate toggle from the phone's. If they're in iCloud on both and still stuck, switching Notes off and on in the Mac's iCloud settings forces a fresh pull.